Skip to content

feat: add telemetry support via jaeger#24

Merged
pat-s merged 11 commits intomainfrom
feat/jaeger
Apr 3, 2026
Merged

feat: add telemetry support via jaeger#24
pat-s merged 11 commits intomainfrom
feat/jaeger

Conversation

@JosiahParry
Copy link
Copy Markdown
Member

Requires https://github.com/ricochet-rs/ricochet/pull/700 to be merged.

Adds an optional jaeger sidecar container. If enabled, injects [otel] into ricochet-config.toml

Copy link
Copy Markdown
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update docs please.

Comment thread charts/ricochet/values.yaml Outdated
Comment thread charts/ricochet/templates/deployment.yaml Outdated
Comment thread charts/ricochet/templates/deployment.yaml Outdated
Comment thread charts/ricochet/templates/configmap-config.yaml Outdated
@pat-s pat-s changed the title feat: add jaeger to helm chart feat: support telemetry via jaeger Feb 17, 2026
@pat-s pat-s changed the title feat: support telemetry via jaeger feat: add telemetry support via jaeger Feb 17, 2026
JosiahParry and others added 4 commits February 17, 2026 11:25
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
Co-authored-by: Patrick Schratz <patrick.schratz@gmail.com>
@JosiahParry JosiahParry requested a review from pat-s February 17, 2026 16:43
Copy link
Copy Markdown
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run just helm-docs (or how it's called) to update the docs :)

Comment thread charts/ricochet/values.yaml Outdated
@JosiahParry
Copy link
Copy Markdown
Member Author

@pat-s can you double check this? I want to make sure I did this correctly

Copy link
Copy Markdown
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run just docs to generate docs.

Comment thread charts/ricochet/values.yaml Outdated
# ricochet-config.toml unless config.'otel' is already set.
enabled: false
# jaeger.image -- Jaeger v2 image to use (avoid latest in production)
image: jaegertracing/jaeger:2.15.1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check this into renovate so we don't have to take care of it.

limits:
memory: 256Mi
# jaeger.initImage -- Busybox image used by the init container to write the Jaeger config
initImage: busybox:1.37
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's check this into renovate so we don't have to take care of it.

@JosiahParry
Copy link
Copy Markdown
Member Author

@pat-s I've updated the resources. Both myself and claude have no idea how to handle renovate. If we'll just update based on every new tag, why not just use :latest? Adding renovate for a sidecar container tag seems like doing too much work.

JosiahParry and others added 2 commits March 18, 2026 14:39
…ates

Extract hardcoded busybox:1.37 from deployment template into values.yaml and add renovate: image comments to enable automated monthly dependency updates via Renovate regex manager.
@pat-s
Copy link
Copy Markdown
Member

pat-s commented Mar 19, 2026

If we'll just update based on every new tag, why not just use :latest?

This question could start a paper-like reply :)

One should never use :latest tags ever anywhere (unless for adhoc local debugging), definitely not in anything templated. Traceability, avoiding pulling "dev" images, etc. There are many good articles on this topic.
While it is less an issue for some images like busybox, it surely is for jaeger.

Copy link
Copy Markdown
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JosiahParry If you're good with my recent changes, please merge.

@pat-s pat-s merged commit b157400 into main Apr 3, 2026
2 checks passed
@pat-s pat-s deleted the feat/jaeger branch April 3, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants