Skip to content

Fix test parsing error by updating locations.js import to ES6 syntax #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richorama merged 3 commits into from
Oct 20, 2025
Merged

Fix test parsing error by updating locations.js import to ES6 syntax #111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9c2cae
Initial plan
Copilot Oct 20, 2025
c00b11a
Fix test to use ES6 import for locations.js
Copilot Oct 20, 2025
808a06c
Fix timeoutId scoping issue in test
Copilot Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions test/cb-endpoints-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,28 +12,15 @@
* npm run test:endpoints
*/

import { readFileSync } from 'fs';
import { fileURLToPath } from 'url';
import { dirname, join } from 'path';
import { dirname } from 'path';

// Get __dirname equivalent for ES modules
const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);

// Read and parse locations.js as text since it's CommonJS
const locationsPath = join(__dirname, '../lib/locations.js');
const locationsContent = readFileSync(locationsPath, 'utf8');

// Use eval to execute the module.exports function in a safe context
// Extract just the function part
const funcMatch = locationsContent.match(/module\.exports = (\(\) => \[[\s\S]*?\]);/);
if (!funcMatch) {
throw new Error('Could not parse locations.js');
}

// Evaluate the function and call it to get the array
const getLocationsFunc = eval(funcMatch[1]);
const getLocations = getLocationsFunc;
// Import locations.js as an ES6 module
import getLocations from '../lib/locations.js';

// Test configuration
const TEST_TIMEOUT = 10000; // 10 seconds
Expand Down Expand Up @@ -82,10 +69,11 @@ async function testEndpoint(location) {
};

const startTime = Date.now();
let timeoutId;

try {
const controller = new AbortController();
const timeoutId = setTimeout(() => controller.abort(), TEST_TIMEOUT);
timeoutId = setTimeout(() => controller.abort(), TEST_TIMEOUT);

const response = await fetch(url, {
method: 'GET',
Expand All @@ -100,7 +88,7 @@ async function testEndpoint(location) {
result.success = true; // Any response (including 404, 500, etc.) is considered successful for latency testing

} catch (error) {
clearTimeout(timeoutId);
if (timeoutId) clearTimeout(timeoutId);

if (error.name === 'AbortError') {
result.responseTime = Date.now() - startTime;
Expand Down