Skip to content

Edit configuration in menu#103

Merged
infeeeee merged 4 commits intorichibrics:mainfrom
infeeeee:edit-config
Mar 8, 2024
Merged

Edit configuration in menu#103
infeeeee merged 4 commits intorichibrics:mainfrom
infeeeee:edit-config

Conversation

@infeeeee
Copy link
Copy Markdown
Collaborator

@infeeeee infeeeee commented Mar 8, 2024

  • Part 3 of App settings again #90 separation
  • Now it's possible to edit existing configurations in the config menu
  • Configuration.py: New classes to store the config, so it's not a simple dict anymore
  • Configurator.py: Duplicate WH/entity methods merged
  • All other changes related to these

It should work now, please report if something is not working as expected.

TODO:

  • Fix terminal entity editing, display_if_key_value not supported yet

@infeeeee infeeeee mentioned this pull request Mar 8, 2024
5 tasks
@infeeeee infeeeee requested a review from richibrics March 8, 2024 01:46
@richibrics
Copy link
Copy Markdown
Owner

Really great, nice job.
I've just edited a bunch of comments I noticed that were harder to understand from who was out of the edits like me :)

@infeeeee infeeeee merged commit 5c1c7ee into richibrics:main Mar 8, 2024
@infeeeee infeeeee deleted the edit-config branch May 3, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants