ClassManager Rewrite

[infeeeee]

• Part 2 of App settings again #90 separation
• Rewrite ClassManager:
  • Use pathlib. It makes a lot of file and directory commands much simpler, nicer and more readable.
  • ClassManager functionality didn't change, merged functions which were called only once, removed unused code.
• New method: MyApp.App.getRootPath(): Returns the absolute filepath of the installation. It can be useful at other situations in the future.

Question to @richibrics:

The 2 subclasses of ClassManager became really short. Maybe they could be replaced by something like this:
EntityClassManager() = ClassManager(KEY_ENTITIES)
WarehouseClassManager() = ClassManager(KEY_WAREHOUSES)

Because these subclasses are differ only by the base path, and I don't really see how they can change in the future.

What do you think of this?

[richibrics]

What would be the key ? The path ? If so, I'd pass a list of path so that it's ready for future implementations of custom entities

[infeeeee]

I would pair the path to the key in consts.py, so we don't have to write the path everywhere ClassManagers are used

[richibrics]

Yes, we could use it with a fixed key. What do you think in pairing the key with a list of paths (for future custom entities) ?

[infeeeee]

I just pushed a new commit, I had to change some parts in Configurator as well for this to work.

It will make the whole Configurator workflow much easier, by having the same class a lot of duplicate methods in Configurator can be merged, but that's for the next PR.

[richibrics]

Great I approve it