Add optional custom event mapping to the domain repository.#44
Open
aelfsyg wants to merge 1 commit intoriccardone:masterfrom
Open
Add optional custom event mapping to the domain repository.#44aelfsyg wants to merge 1 commit intoriccardone:masterfrom
aelfsyg wants to merge 1 commit intoriccardone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a custom
EventTypeto class mapping to be used by the domain repository when it deserilaises events to rebuild the aggregate.It extracts common code from the two existing
GetByIdmethods intoGetByIdInternal, and addresses many compiler warnings caused by missing null checks and possible NREs.The test has not been implemented due to difficulty I had in faking Event Store's internal and protected classes.