Code Reviews Checklist

Markup

• Code does not contain inline JavaScript event listeners.
• Code does not contain inline style attributes.
• Code does not contain deprecated elements & attributes.
• Tags and attributes are lowercase.
• Tags are closed and nested properly.
• Markup is semantic.
• Tables are only used to display tabular data.
• Element IDs are unique.
• No text is included via images.

Forms

• Validate user input before making http requests and functions can appropriately handle unexpected inputs.
• Form elements are paired with labels elements containing the for attribute.

CSS

• Style blocks are externalized to .css files.
• Consistent naming conventions are used.
• CSS sprites are used to combine images.
• CSS selectors gets more specific across files.
• Use responsive classes from Bootstrap.
• Includes mobile breakpoints properly defined.

Accessibility

• Page has a proper outline (H1-H6 order).
• Alt attributes exist on all img elements.
• Tabindex order is logical and intuitive.

JavaScript

• Script blocks are externalized to .js files.
• Consistent naming conventions are used.
• No functions or variables in the global namespace.
• All defined vars are used.
• No unnecessarily duplicated logic.
• Handle null and empty object scenarios.
• Code does not contain leftovers like console logs, commented code blocks, etc.
• Code properly documented where needed.
• There are tests for the proposed functionality and all passed.
• Code passes jshint without errors.

AngularJS

• Checkout Todd Motto best practices style guide