Adding netbox support for EgressIP for OcpSandbox #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridim
requested changes
Jul 1, 2025
internal/models/ocp_sandbox.go
Outdated
| "egressIPs": []string{strings.Split(egressIPAvailable, "/")[0]}, | ||
| "namespaceSelector": map[string]any{ | ||
| "matchLabels": map[string]any{ | ||
| "guid": guid, // The label selector for the Keycloak realm |
Contributor
There was a problem hiding this comment.
can we use service_uuid instead?
Contributor
There was a problem hiding this comment.
Shouldn't we add some logic in the Candidate loop to check:
- if the annotation egressip is there
- make sure the cluster has an availableIP
- otherwise => move to the next one
?
| egressIPAvailable, err = netbox.RequestIP(selectedCluster.NetboxApiUrl, selectedCluster.NetboxToken, rnew.ServiceUuid) | ||
| log.Logger.Info("selectedCluster", "egressip", egressIPAvailable) | ||
| if err != nil { | ||
| log.Logger.Error("Error creating EgressIP", "error", err) |
| if ok && egressIP != "" { | ||
| err = netbox.ReleaseIP(cluster.NetboxApiUrl, cluster.NetboxToken, egressIP+"/"+deletens.Labels["egressNetmask"]) | ||
| if err != nil { | ||
| log.Logger.Error("Error deleting egressIP on netbox", egressIP, err) |
Contributor
There was a problem hiding this comment.
we should make this fatal, no?
Releasing the IP should work, otherwise consider the delete as fail, and don't proceed. Retry later
Otherwise it's going to leak IPs?
Problem is if something goes wrong here with the netboxapi, then namespaces aren't deleted
Not sure how we can address that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering a OcpSandbox, sandbox will do:
If connection or if there is any error getting the Egressip, is ignored and throwing error to the log.
Idea EgressIP is not, at this point, blocking the provisioning.