Add assert.equal and assert.strictEqual#1
Open
lee-houghton wants to merge 3 commits intorhoot:masterfrom
Open
Conversation
…xtraction, but including the values of the things which were not the same.
I can't type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I like this library, it makes writing assertions much DRYer! But I did miss being able to assert that two things are equal and having the error message include the values of the things that were different, rather than just the names. I added an
assert.equalandassert.strictEqual, and thought it might be useful to make a pull request...I've extracted the source code extraction into a
failfunction, which takes an optionalextraMessageparameter to give a bit more information about the error. I've only implementedassert.equalandassert.strictEqual, though I'm sure something likeassert.deepEqualwould be useful too. I've usedutil.inspectfor stringifying the values.