COO-1531: feat: expose AlertmanagerConfigMatcherStrategy on MonitoringStack#1092
COO-1531: feat: expose AlertmanagerConfigMatcherStrategy on MonitoringStack#1092jan--f wants to merge 1 commit into
Conversation
|
@jan--f: This pull request references COO-1531 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…O-1531) AlertmanagerConfig resources automatically inject a namespace matcher into routes, forcing users to add namespace labels to PrometheusRule alerts. Expose the matcherStrategy field on MonitoringStack.Spec.AlertmanagerConfig with a default of None so routes match all alerts regardless of namespace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
jan--f
force-pushed
the
feat/alertmanaer-strategy
branch
from
bdc3562 to
130cab7
Compare
|
/cc @jan--f |
|
@simonpasquier: GitHub didn't allow me to request PR reviews from the following users: jan--f. Note that only rhobs members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
simonpasquier
left a comment
simonpasquier
left a comment
There was a problem hiding this comment.
The upstream struct has an inner type field which offers the possibility to pass additional parameters if required for new strategies:
spec:
alertmanagerConfigMatcherStrategy:
type: OnFooBar
fooBar:
foo: x
bar: y
It might be good to follow a similar pattern for MonitoringStack?
spec:
alertmanager
configMatcherStrategy:
type: None
3 participants
AlertmanagerConfig resources automatically inject a namespace matcher into routes, forcing users to add namespace labels to PrometheusRule alerts. Expose the matcherStrategy field on MonitoringStack.Spec.AlertmanagerConfig with a default of None so routes match all alerts regardless of namespace.