Skip to content

Update grafana version to 8.3.5 in docker-compose.yml #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaSharma14 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update grafana version to 8.3.5 in docker-compose.yml #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ services:
- DASHBOARD_URL=${DASHBOARD_URL:-https://ceph2:11000}

grafana:
image: ${GRAFANA_IMAGE:-ceph/ceph-grafana}
image: ${GRAFANA_IMAGE:-quay.io/ceph/ceph-grafana:8.3.5}
Copy link
Member

@nizamial09 nizamial09 Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaSharma14 while testing this I realized that I just had to do a docker-compose pull grafana in local to pull the latest grafana image. Because ceph/ceph-grafana should pull the latest image in the repo right? And if we pin the grafana version we'll have to change it again once we push a newer version in ceph/ceph-grafana.

I don't think we need to worry about version pinning here since we are the only ones who is going to push to ceph/ceph-grafana.

The other thing is the quay.io. if we don't provide it, does the docker-compose pull the image from docker or quay?

container_name: grafana
hostname: grafana
user: "0:0"
Expand Down