Adding delete to modulebuildsignconfigs rbac#1750
Adding delete to modulebuildsignconfigs rbac#1750ybettan merged 1 commit intorh-ecosystem-edge:mainfrom
Conversation
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughRBAC permissions are being updated and consolidated across manifest files and controller annotations. The Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/hold |
|
@coderabbitai pause |
✅ Actions performedReviews paused. |
|
/unhold |
Following "Add imageRebuildTrigger field to force module image rebuilds" commit, we now deleting mbsc resources from the controllers (regular + hub) pods, but since we missed the rbac annotation for that, it failed to delete. This commits adds the missing rbac annotation.
TomerNewman
force-pushed
the
bugfix/add-mbsc-delete-rbac
branch
from
3e662d8 to
a6ba8d3
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
1 similar comment
|
/lgtm |
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
@TomerNewman: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/retest |
|
/override e2e There is an issue with the ci clusterpool so no cluster is accecible for us. see here for more reference |
|
@TomerNewman: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e |
|
@TomerNewman: Overrode contexts on behalf of TomerNewman: ci/prow/e2e, ci/prow/e2e-hub, ci/prow/operator-hub-upgrade, ci/prow/operator-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@TomerNewman: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Following #1725 commit, we now deleting mbsc resources from the controllers (regular + hub) pods, but since we missed the rbac annotation for that, it failed to delete.
This commits adds the missing rbac annotation.
/cc @ybettan @yevgeny-shnaidman
fixes #1751
Summary by CodeRabbit