Skip to content

Add github workflow to automatically run tests for netcdf to json conversion#16

Draft
glemieux wants to merge 5 commits into
rgknox:netcdf_to_jsonfrom
glemieux:netcdf_to_json_test
Draft

Add github workflow to automatically run tests for netcdf to json conversion#16
glemieux wants to merge 5 commits into
rgknox:netcdf_to_jsonfrom
glemieux:netcdf_to_json_test

Conversation

@glemieux
Copy link
Copy Markdown
Collaborator

@glemieux glemieux commented May 5, 2026

This adds a github workflow to run the netcdf_to_json.py script. It will generate an nc file from an archived cdl file and then run the script.

Description:

Collaborators:

Expectation of Answer Changes:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the in-code documentation .AND. (the technical note .OR. the wiki) accordingly.
  • I have read the CONTRIBUTING document.
  • FATES PASS/FAIL regression tests were run
  • If answers were expected to change, evaluation was performed and provided

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux changed the base branch from master to netcdf_to_json May 5, 2026 18:15
@glemieux
Copy link
Copy Markdown
Collaborator Author

glemieux commented May 5, 2026

For me: I don't understand why there are so many file changes here. Retargeting the branch fixed it.

Potential things to add to this:

  • Add pytest unit tests to check failing cases
  • Add test that modifies the archived cdl with dummy variables to exercise integer variable types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant