Skip to content

Add optional window-open thermostat priority#759

Merged
rg-engineering merged 1 commit intorg-engineering:masterfrom
softwarecrash:master
Mar 16, 2026
Merged

Add optional window-open thermostat priority#759
rg-engineering merged 1 commit intorg-engineering:masterfrom
softwarecrash:master

Conversation

@softwarecrash
Copy link

Summary

This PR adds a new optional setting:

  • Window open has priority over thermostat

When this option is enabled, thermostat target changes are ignored while a room is in WindowOpen state, and the reduced window-open target is actively re-applied.

Background

In the current behavior, a room can already be reduced because a window is open, but a later target update from the thermostat may still arrive after reconnects, restarts, or delayed device updates.

In that situation the adapter may log messages like:

  • manual mode <target> but ignored because already reduced
  • override mode <target> but ignored because already reduced

The problem is that the value is ignored internally, but the reduced target is not written again to the thermostat. This can leave the thermostat on a higher target although the room is still in WindowOpen.

Changes

  • add the new admin setting Window open has priority over thermostat
  • ignore thermostat target updates while the window is open if the option is enabled
  • trigger re-application of the reduced target in this case
  • add translations for the new option

Additional fixes

  • fix wrong clearTimeout usage in override timer handling
  • fix wrong clearTimeout usage in window-open-until-temperature handling
  • fix cleanup of ChangeStatusCmdList
  • fix usage of ActorBeforeOnDelay
  • fix weekday fallback for profile type 3 on Wednesday

@rg-engineering rg-engineering merged commit f100a5f into rg-engineering:master Mar 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants