Add optional window-open thermostat priority#759
Merged
rg-engineering merged 1 commit intorg-engineering:masterfrom Mar 16, 2026
Merged
Add optional window-open thermostat priority#759rg-engineering merged 1 commit intorg-engineering:masterfrom
rg-engineering merged 1 commit intorg-engineering:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new optional setting:
Window open has priority over thermostatWhen this option is enabled, thermostat target changes are ignored while a room is in
WindowOpenstate, and the reduced window-open target is actively re-applied.Background
In the current behavior, a room can already be reduced because a window is open, but a later target update from the thermostat may still arrive after reconnects, restarts, or delayed device updates.
In that situation the adapter may log messages like:
manual mode <target> but ignored because already reducedoverride mode <target> but ignored because already reducedThe problem is that the value is ignored internally, but the reduced target is not written again to the thermostat. This can leave the thermostat on a higher target although the room is still in
WindowOpen.Changes
Window open has priority over thermostatAdditional fixes
clearTimeoutusage in override timer handlingclearTimeoutusage in window-open-until-temperature handlingChangeStatusCmdListActorBeforeOnDelay