Clarify matrix-vector mapping in the HiSSE tutorial#56
Open
davidcerny wants to merge 4 commits intosourcefrom
Open
Clarify matrix-vector mapping in the HiSSE tutorial#56davidcerny wants to merge 4 commits intosourcefrom
davidcerny wants to merge 4 commits intosourcefrom
Conversation
brpetrucci
approved these changes
Apr 21, 2025
Contributor
brpetrucci
left a comment
brpetrucci
left a comment
There was a problem hiding this comment.
Looks good! Maybe would be good to have a comment like this under the hidden rate definitions instead, to clarify which rate transitions are e.g. q0A->1A vs. q0A->0B etc? But this change is useful regardless!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a small addition to the HiSSE tutorial inspired by the question we received in issue #660: without specifying whether we fill the rate matrix by column or by row, it's not clear which elements of the
transition_ratesvector correspond to which rates.