Compute checksums for wallet descriptors without bitcoind#364
Open
JSwambo wants to merge 1 commit intorevault:masterfrom
Open
Compute checksums for wallet descriptors without bitcoind#364JSwambo wants to merge 1 commit intorevault:masterfrom
JSwambo wants to merge 1 commit intorevault:masterfrom
Conversation
Member
Author
|
When I test locally I don't get the same failure with |
Member
|
Yeah, spurious failure fixed by #361 . Rebasing on master should fix it. |
The desc_checksum function and poly_mod were taken from rust-miniscript: https://github.com/rust-bitcoin/rust-miniscript/blob/master/src/descriptor/checksum.rs Hopefully the desc_checksum function will be publicly exposed in the future and we can remove it.
JSwambo
force-pushed
the
fix_checksum
branch
from
01f24fa to
b08f5a3
Compare
darosior
reviewed
Feb 22, 2022
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
The cosigner submodule change looks unrelated?..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desc_checksum function and poly_mod were taken from rust-miniscript: https://github.com/rust-bitcoin/rust-miniscript/blob/master/src/descriptor/checksum.rs
Hopefully the desc_checksum function will be publicly exposed in the future and we can remove it.
Fixes #322