Dynamic feebumping riddance#122
Merged
darosior merged 14 commits intorevault:masterfrom May 6, 2022
Merged
Conversation
darosior
force-pushed
the
feebumping_riddance
branch
3 times, most recently
from
121e082 to
d972edc
Compare
darosior
force-pushed
the
feebumping_riddance
branch
2 times, most recently
from
46ed4fa to
6d0ad62
Compare
edouardparis
reviewed
May 5, 2022
edouardparis
reviewed
May 5, 2022
| feerate_20: CancelTransaction::new( | ||
| unvault_txin.clone(), | ||
| &der_deposit_descriptor, | ||
| Amount::from_sat(5), // vbytes to WU |
Member
There was a problem hiding this comment.
note to self: 1 vbyte = 4 WU
edouardparis
approved these changes
May 5, 2022
Member
edouardparis
left a comment
edouardparis
left a comment
There was a problem hiding this comment.
one nit. fuzzing and testing gives me no errors
This is now a valid check for all presigned txs, no need to have a separate helper anymore.
There is conceptually a distinction between the Unvault, Cancel, Emergency's on one hand and the Spend on the other hand. We treat them differently in revaultd, and we've already been in the situation where we wanted a function to generalistically take a Cancel, Unvault, Emergency but not a Spend transaction. However, it was previously convoluted to introduce a type distinction between those, as the Unvault was still pretty different from the revocation transactions. Now that all the presigned transactions are single-input and signed with ALL, this is possible to merge the common implementation of sighash() and add_sig() for the first and single input into a single trait. This also enables the type distinction that will turn out to be useful downstream.
It's always SIGHASH_ALL now!
…puts We don't need it anymore.
Transaction never have more than 1 input anymore.
darosior
force-pushed
the
feebumping_riddance
branch
from
8837216 to
461d83f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements revault/practical-revault#119.
The conceptual simplification of the transactions management enabled some cleanups and refactorings, which i jumped on right away in this PR.