First step toward static feebumping#25
Merged
darosior merged 8 commits intorevault:masterfrom May 13, 2022
Merged
Conversation
darosior
force-pushed
the
static_feebumping
branch
from
992ca42 to
59e9fe1
Compare
Member
Author
|
Rebased |
darosior
force-pushed
the
static_feebumping
branch
from
59e9fe1 to
cefc8e4
Compare
darosior
force-pushed
the
static_feebumping
branch
4 times, most recently
from
d56cd27 to
bfe5c31
Compare
darosior
force-pushed
the
static_feebumping
branch
from
bfe5c31 to
25319b3
Compare
edouardparis
reviewed
May 5, 2022
darosior
force-pushed
the
static_feebumping
branch
from
25319b3 to
4c9ed5b
Compare
Member
Author
|
Thanks i hadn't run clippy 🙊 |
darosior
force-pushed
the
static_feebumping
branch
2 times, most recently
from
6a98572 to
128c7f8
Compare
We use a custom pytest marker to optionally create a proxy server in-between miradord and bitcoind, to optionally mock some RPC calls made from the former to the latter.
…martfee We adapt the feerate of the Cancel we'll broadcast to the feerate market conditions. We still need a fallback estimation and to implement re-bumping but it's a first step toward static fee-bumping for the WT.
darosior
force-pushed
the
static_feebumping
branch
from
128c7f8 to
390bda4
Compare
Member
Author
|
@edouardparis if you can have another look, i think it's RFM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements revault/practical-revault#119.
We start by adapting the listener to the new messages, and make it treat incoming Cancel signatures for the various Cancel transactions (where it previously only had to manage for a single one).
We continue by adapting the poller loop to choose the correct Cancel transaction to broadcast depending on the fee estimates. This is only a first step, more needs to be considered for a proper fee bumping integration.
Finally, we get rid of the fee bumping wallet mentions: we are not doing that anymore (for the time being).