🐛 Fix MCP path validation rejecting valid Windows paths in WSL#40
Merged
Conversation
Replace filepath.IsAbs() checks with OS-aware descriptions in MCP tool parameters. filepath.IsAbs() uses compile-time OS semantics, so a Linux binary (e.g. running in WSL) would reject valid Windows paths like C:\Users\... sent by a Windows MCP client. Tool descriptions now include the correct path format for the compiled OS, guiding the LLM client to send the right path on the first call.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes filepath.IsAbs() validation in MCP tool handlers (which used compile-time OS semantics and rejected valid Windows paths from a Linux/WSL server) and replaces it with OS-aware hints in the tool parameter descriptions to guide MCP clients.
Changes:
- Drop
path/filepathimport; addruntimeto detect server OS. - Remove absolute-path validation for
output_dir,local_paths, andlocal_dir. - Add
absPathHinttext to relevant tool parameter descriptions in bothregisterTransferToolsandregisterDataroomTools.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace filepath.IsAbs() checks with OS-aware descriptions in MCP tool parameters. filepath.IsAbs() uses compile-time OS semantics, so a Linux binary (e.g. running in WSL) would reject valid Windows paths like C:\Users... sent by a Windows MCP client.
Tool descriptions now include the correct path format for the compiled OS, guiding the LLM client to send the right path on the first call.