feat: project specific config#303
Open
richard-hajek wants to merge 2 commits intorest-sh:mainfrom
Open
Conversation
Author
|
I already noticed few issues
I do not recommend to merge this at this stage |
…e validation - Load all .restish.json/.restish.yaml files from current directory up to root - Deep merge API configs and profiles across multiple files (headers, query params, etc.) - Replace panic() calls with graceful error handling showing available profiles - Add interactive menu to choose which config file to save when editing - Track all config sources for each API to enable proper save targeting - By default, save to the closest (most specific) config file This enables hierarchical config organization (e.g., project root + team + developer overrides) while maintaining a smooth editing experience with restish apis edit. Fixes issues with random crashes on invalid profile selection and clarifies the behavior of local config editing.
Author
|
I believe i fixed most of the issues in this PR |
|
Hi. I was looking for this feature and tried out your PR and have a few remarks:
Generally, I would advise against doing any merging of config files. If a custom config file is specified with |
Author
|
Thanks for the review! I don't use restish as frequently right now, so it's not a high priority for me, but I'll try to get to it at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #239
Fair warning, this work is vibe coded. However I tested it and It Works On My Machine ™️