Hi Gareth, I know you're there, please pull.#1
Open
jvillard wants to merge 4 commits intoresource-reasoning:masterfrom
Open
Hi Gareth, I know you're there, please pull.#1jvillard wants to merge 4 commits intoresource-reasoning:masterfrom
jvillard wants to merge 4 commits intoresource-reasoning:masterfrom
Conversation
added 4 commits
October 25, 2011 22:22
applyConcurrentDiff crashes when accessing changeLog[df.uid].length otherwise.
seems appropriate.
namely makeDiff, makeDel, and makeInsert
The previous algo could fail as i + j could be > oldStr.length. This results in a negative delete (urgh). For instance: oldStr = "aaa" newStr = "aabaaa" gives i = 2 and j = 3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wouldn't let me commit so I thought I'd have some fun with github and savagely forked your repo.