DCE: Make analysis phase return AnalysisResult.t (Task 8) #8073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes Tasks 8 and 8b of the DCE refactor plan, making the analysis
phase fully pure - returning an immutable AnalysisResult.t with no inline logging.
Key changes:
- Add AnalysisResult module with immutable result type and issue constructors
- makeDeadIssue: pure function to create dead code issues
- Decl.report: returns issue list (includes dead module + dead value issues)
- DeadOptionalArgs.check: returns issue list instead of logging
- DeadModules.checkModuleDead: returns issue option instead of logging
- reportDead: returns AnalysisResult.t, caller logs issues
- resolveRecursiveRefs: collects all issues (optional args, incorrect annotations)
via ~issues ref instead of logging inline
Architecture after this change:
merged_view (immutable)
│
▼
reportDead (pure function, no logging)
│
▼
AnalysisResult.t (immutable)
│
▼
report (all side effects here)
cristianoc
force-pushed
the
dce-analysis-result
branch
from
d2a4278 to
9105092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes Task 8 of the DCE refactor plan, making the analysis phase return an immutable AnalysisResult.t instead of logging directly.
Key changes:
Architecture after this change:
merged_view (immutable) │ ▼ reportDead (pure function) │ ▼ AnalysisResult.t (immutable) │ ▼ report (side effects here only)
Note: Optional args and incorrect annotation issues are still logged inline during resolveRecursiveRefs. A future task could collect these as well.