Skip to content

refactor: move runtime capability access away from Global window and navigator#247

Merged
jderochervlk merged 4 commits into
pre-alphafrom
issue-241-runtime-access
Apr 18, 2026
Merged

refactor: move runtime capability access away from Global window and navigator#247
jderochervlk merged 4 commits into
pre-alphafrom
issue-241-runtime-access

Conversation

@jderochervlk
Copy link
Copy Markdown
Collaborator

Summary

  • remove Global.window and Global.navigator from the public
    runtime access path
  • add owner-module entrypoints such as History.current,
    Storage.local, Storage.session, Performance.current, Crypto.current, and worker/
    service-worker current accessors
  • update runtime-facing tests to use the owner modules
    instead of Global.window and Global.navigator

Validation

  • npm run build
  • npm test

Related

@jderochervlk jderochervlk requested review from brnrdog and tsnobip April 18, 2026 14:00
open ClipboardTypes

include EventTarget.Impl({type t = clipboard})
type t = ClipboardTypes.clipboard = {...ClipboardTypes.clipboard}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should add a short comment just explaining this pattern for future ref

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on updating the readme and contributor docs to cover this once we're ready to finish tidying things up.

Copy link
Copy Markdown
Collaborator

@brnrdog brnrdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jderochervlk jderochervlk merged commit b7f8547 into pre-alpha Apr 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants