Skip to content

Export POE2 passive tree images#62

Draft
tskimmett wants to merge 4 commits into
repoe-fork:masterfrom
tskimmett:feat/poe2-passive-image-exports
Draft

Export POE2 passive tree images#62
tskimmett wants to merge 4 commits into
repoe-fork:masterfrom
tskimmett:feat/poe2-passive-image-exports

Conversation

@tskimmett
Copy link
Copy Markdown

@tskimmett tskimmett commented May 25, 2026

  • export POE2 ascendancy node icons during English passive data generation
  • export ascendancy passive tree images and character base class passive tree illustrations
  • allow characters output validation to accept passive_tree_image
  • avoid POE2 passive parser crash by removing skills_per_orbit access

Comment thread RePoE/parser/poe2/passives.py Outdated
"title": tree["Name"]["Text"],
"roots": psg.root_passives,
"skills_per_orbit": psg.skills_per_orbit,
# "skills_per_orbit": psg.skills_per_orbit,
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was crashing when I ran the exporter locally. Not sure if it's needed?

@tskimmett tskimmett marked this pull request as ready for review May 25, 2026 04:57
@lvlvllvlvllvlvl
Copy link
Copy Markdown
Member

I would prefer not to add more images to the github export. I believe l have fixed the issues with ggpk.exposed so it should be possible to serve images from there, e.g https://image.ggpk.exposed/poe2/Art/2DArt/SkillIcons/passives/PathFinder/PathfinderNode.dds

@lvlvllvlvllvlvl
Copy link
Copy Markdown
Member

skills_per_orbit was a requested feature https://discord.com/channels/174993814845521922/175290321695932416/1452852444928282748

I'm not sure why that line would crash, it just assigns the existing array from the parsed data? If it's a data-model issue you could try poetry run pre-commit run --all to ensure the pydantic models are up-to-date with the json schemas.

@tskimmett
Copy link
Copy Markdown
Author

@lvlvllvlvllvlvl Got it. I will revise this to avoid the additional exports and I'll check that the models are up to date. Thank you 🙏

@tskimmett tskimmett marked this pull request as draft May 25, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants