Handle fatal connection attempt errors#385
Merged
Merged
Conversation
cbrewster
approved these changes
Jun 26, 2026
21eaa36 to
3595ae4
Compare
3595ae4 to
1ffd06e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
River exposes
isFatalConnectionErrorso callers can stop retrying connection failures that are permanent. That hook was only honored after a connection had been established, so fatal failures during the initial connection attempt still retried until the retry budget or session grace behavior kicked in.This is needed for pid2 auth failures where the target repl is gone: callers can classify that as fatal and avoid the noisy retry loop.
What changed
isFatalConnectionErrorin the initialonConnectionFailedpath.@replit/riverto0.219.0.Versioning
Test plan
direnv exec . npm run checkdirenv exec . npm exec -- vitest run