Skip to content
This repository was archived by the owner on Mar 24, 2023. It is now read-only.

Fix bitbucket upstreams#1048

Open
laverya wants to merge 3 commits intoreplicatedhq:mainfrom
laverya:fix-bitbucket-upstreams
Open

Fix bitbucket upstreams#1048
laverya wants to merge 3 commits intoreplicatedhq:mainfrom
laverya:fix-bitbucket-upstreams

Conversation

@laverya
Copy link
Member

@laverya laverya commented Aug 22, 2019

What I Did

Updated go-getter to include a fix for bitbucket upstreams, as hashicorp/go-getter#183 has been resolved by hashicorp/go-getter#189.

How I Did it

How to verify it

Bitbucket upstream unit tests have been reincluded.

Description for the Changelog

Bitbucket upstreams are once again supported

Picture of a Ship (not required but encouraged)

USS Saipan (CVL-48)

@laverya laverya requested a review from emosbaugh August 22, 2019 18:53
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 75928 lines exceeds the maximum allowed for the inline comments feature.

emosbaugh
emosbaugh previously approved these changes Aug 22, 2019
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 75928 lines exceeds the maximum allowed for the inline comments feature.

@laverya
Copy link
Member Author

laverya commented Aug 22, 2019

So it looks like the istio failures are legitimate failures, and not something that's happening randomly
I'll have to investigate this further

@chase-replicated chase-replicated deleted the branch replicatedhq:main December 9, 2021 00:22
@chase-replicated chase-replicated changed the base branch from master to main December 9, 2021 02:39
@chase-replicated chase-replicated dismissed emosbaugh’s stale review December 9, 2021 02:39

The base branch was changed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants