Open
Conversation
crdant
force-pushed
the
crdant/fix/smoke-chart-version
branch
2 times, most recently
from
3f8cc28 to
700ac60
Compare
jdewinne
requested changes
Jul 5, 2023
Member
jdewinne
left a comment
jdewinne
left a comment
There was a problem hiding this comment.
I would do this different, and in the case of helm, automatically extract the app version from the Chart.yaml, vs having it dynamic.
| if: inputs.version == '' | ||
| shell: bash | ||
| run: | | ||
| tarball=$(find ${YAML_DIR} -name "${CHART_NAME}*.tgz") |
Member
There was a problem hiding this comment.
I guess this will break if the yaml-dir doesn't contain a helm chart?
Member
Author
There was a problem hiding this comment.
yes, all the manipulation of the chart will break, I should make those conditional
Member
Author
There was a problem hiding this comment.
made a few more things conditional
crdant
force-pushed
the
crdant/fix/smoke-chart-version
branch
from
4937047 to
700ac60
Compare
Member
|
@crdant this has been a while, is it still needing review or is it no longer required? |
Member
Author
I've generally moved away from our actions so I'm not sure. Happy to check it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Makes sure versions are aligned when running smoke tests
Details
Replaces hardcode major.minor.patch of
0.0.1from the version used in the smoke action and replaces it with the version from the Helm chart'sChart.yaml. I thought that would be all that was required to fix the400on release, but it wasn't. So now the smoke test also updatesChart.yamlwith the version that it creates to use for the test release. This required by the strict rules the vendor portal has for validating that the release version matches the chart version.Ideally we could stash the build related tagging into the build metadata fragment of the semver instead of the prerelease version, and the vendor portal could ignore build metadata.