-
Notifications
You must be signed in to change notification settings - Fork 9
Update Makefile versions #3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update Makefile versions #3023
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
36d59b2 to
e9a9c5e
Compare
4ed6bed to
890d1a0
Compare
24b9de2 to
c5cc899
Compare
6844210 to
cf3ebab
Compare
a6448d8 to
21f3031
Compare
df8c750 to
4e0d524
Compare
|
|
||
| # Helm Version | ||
| HELM_VERSION = v3.19.0 | ||
| HELM_VERSION = v4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Helm Upgrade: Dependency Mismatch Risk
The HELM_VERSION upgrade from v3.19.0 to v4.0.0 creates a version mismatch with the Go dependencies. The codebase imports helm.sh/helm/v3 packages throughout (see go.mod and multiple controller files), but the Makefile now downloads the Helm v4.0.0 binary. This major version jump between the Go libraries and the binary could cause compatibility issues since the code uses both the Helm Go SDK and executes the Helm binary directly. A major version upgrade requires updating the Go dependencies and testing for breaking changes.
829fda0 to
f4a4a18
Compare
f4a4a18 to
1ae300a
Compare
Automated changes by the cron-makefile-dependencies GitHub action