Issue 173: Added ability to provide Custom Rulesets#172
Open
amthorn wants to merge 5 commits intoreplicatedhq:mainfrom
Open
Issue 173: Added ability to provide Custom Rulesets#172amthorn wants to merge 5 commits intoreplicatedhq:mainfrom
amthorn wants to merge 5 commits intoreplicatedhq:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom rulesets is a standard with many linters and provides flexibility for users to create their own linting rules that may apply only to their company or project.
What I changed
Why I changed it
I work for Cisco Systems that is implementing a dockerfile linter. I am using this repository in that effort and i have to patch this package to be able to supply my own custom rulesets for Cisco Standards. I am also patching this library to be able to provide a "severity" to choose whether or not certain rules cause the exit code to be non-zero. But that is something i can submit if this PR is approved.
How I tested it
I only needed to add a single test to verify rulesets work appropriately by adding a custom test ruleset and a custom negative test dockerfile into the examples folder. Here is the result of "npm run test"
Thanks:) Let me know if you need anything.