Add support for all callable type not just Closure#113
Open
sunkan wants to merge 2 commits intorepejota:developfrom
Open
Add support for all callable type not just Closure#113sunkan wants to merge 2 commits intorepejota:developfrom
sunkan wants to merge 2 commits intorepejota:developfrom
Conversation
added 2 commits
October 16, 2017 17:57
Added a test for the new behavior. composer.json - Added test folder to autoload if in devmode phpunit.xml.dist - Fixed path to test folder
Author
|
Why do you have 2 conflicting coding standard. It's really confusing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed support to use classes as callback argument.
And
Closureis also acallableso no this did't break any tests.I know the test isn't the best if someone can give me some pointer I would gladly improve it.