-
Notifications
You must be signed in to change notification settings - Fork 38
chore: resolve dependabot alerts for storybook and lodash #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update storybook to 8.6.15 in apps/gallery and all related @storybook/* packages to the same version for consistency. Update lodash to 4.17.23 in examples/expo-multichain via overrides. Add comprehensive Dependabot alert resolution guidance to AGENTS.md. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
|
Claude finished @ignaciosantise's task —— View job Code Review Complete ✅SummaryThis PR properly resolves Dependabot alerts for Storybook and lodash dependencies. The changes are well-structured and follow the repository's dependency management patterns. Issues Found1. Missing Changeset for Gallery App UpdatesSeverity: Medium The changeset-bot correctly identified that no changeset was added. While this is a Recommendation: Add a changeset for yarn changeset addSelect 2. Inconsistent Documentation GuidanceSeverity: Low The new Dependabot guidance states:
However, this contradicts the repository's existing pattern. The root Recommendation: Revise the guidance to clarify when each approach should be used:
The current implementation in this PR is actually correct (storybook updated in apps/gallery/package.json, lodash override added to expo-multichain/package.json), but the documentation could be clearer about the distinction. 3. Potential Version Inconsistency RiskSeverity: Low The Recommendation: Monitor for any compatibility warnings when running the gallery app. This is likely fine, but document if any issues arise. What Was Done Well✅ Comprehensive storybook update - All @storybook/* packages updated consistently to 8.6.15 (this fixes incomplete Dependabot PR #163700bb which only updated the main ✅ Correct lodash implementation - Using ✅ Lockfile updates - Both yarn.lock and package-lock.json properly updated ✅ Documentation addition - AGENTS.md now includes helpful Dependabot resolution guidance ✅ No breaking changes - Updates are minor/patch versions only (8.3.0 → 8.6.15, 4.17.21 → 4.17.23) ✅ Follows commit convention - Uses Test Plan VerificationThe stated test plan is appropriate:
Additional recommendations:
Final RecommendationApprove with minor changes: Add a changeset for the gallery app updates, then merge. The core dependency updates are solid and address the security alerts properly. The documentation could be refined but doesn't block merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to resolve Dependabot security alerts by updating storybook to version 8.6.15 and lodash to version 4.17.23. It also adds comprehensive documentation about handling Dependabot alerts to the AGENTS.md file.
Changes:
- Updated all storybook packages from ^8.3.0 to ^8.6.15 in apps/gallery
- Updated lodash to 4.17.23 via overrides in examples/expo-multichain
- Added Dependabot alert resolution guidance to AGENTS.md
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/gallery/package.json | Updated all @storybook/* packages and storybook to ^8.6.15 for consistency |
| yarn.lock | Reflects updated storybook package versions and checksums for 8.6.15 |
| examples/expo-multichain/package.json | Added lodash 4.17.23 to overrides field (invalid version) |
| examples/expo-multichain/package-lock.json | Updated lodash entry to version 4.17.23 (invalid version) |
| AGENTS.md | Added comprehensive guidance on resolving Dependabot alerts and dependency updates |
Files not reviewed (1)
- examples/expo-multichain/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
9b997c7 to
6b1867a
Compare
|



Summary
Test Plan
🤖 Generated with Claude Code
Note
Dependency updates
apps/galleryto^8.6.15and aligns all@storybook/*andstorybookentries inyarn.locklodash@4.17.23viaoverridesinexamples/expo-multichain/package.jsonand updatespackage-lock.jsonDocumentation
AGENTS.md(direct vs transitive updates, lockfile updates, related packages, no major bumps, formatting)Written by Cursor Bugbot for commit 6b1867a. This will update automatically on new commits. Configure here.