Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

This pull request introduces a patch to multiple React Native packages to fix how approved networks and the "support all networks" flag are set when connecting wallets.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 648b95c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@reown/appkit-scaffold-react-native Patch
@reown/appkit-ethers5-react-native Patch
@reown/appkit-ethers-react-native Patch
@reown/appkit-wagmi-react-native Patch
@reown/appkit-core-react-native Patch
@reown/appkit-auth-ethers-react-native Patch
@reown/appkit-auth-wagmi-react-native Patch
@reown/appkit-react-native-cli Patch
@reown/appkit-coinbase-ethers-react-native Patch
@reown/appkit-coinbase-wagmi-react-native Patch
@reown/appkit-common-react-native Patch
@reown/appkit-scaffold-utils-react-native Patch
@reown/appkit-siwe-react-native Patch
@reown/appkit-ui-react-native Patch
@reown/appkit-wallet-react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

cursor[bot]

This comment was marked as outdated.

@socket-security
Copy link

socket-security bot commented Aug 22, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​storybook/​theming@​8.6.141001004792100
Added@​babel/​plugin-transform-react-jsx-development@​7.22.51001005989100
Added@​babel/​plugin-syntax-export-namespace-from@​7.8.31001006081100
Added@​babel/​plugin-syntax-private-property-in-object@​7.14.51001006081100
Added@​babel/​plugin-syntax-class-static-block@​7.14.51001006181100
Added@​babel/​plugin-syntax-import-assertions@​7.22.51001006189100
Added@​babel/​plugin-transform-dotall-regex@​7.22.51001006189100
Added@​babel/​plugin-syntax-unicode-sets-regex@​7.18.61001006281100
Added@​storybook/​react-webpack5@​8.6.1410010062100100
Added@​babel/​plugin-transform-unicode-sets-regex@​7.22.51001006289100
Added@​babel/​plugin-transform-exponentiation-operator@​7.22.51001006389100
Added@​babel/​plugin-transform-reserved-words@​7.22.51001006389100
Added@​babel/​plugin-transform-unicode-property-regex@​7.22.51001006489100
Added@​babel/​plugin-syntax-import-attributes@​7.22.51001006489100
Added@​storybook/​addon-webpack5-compiler-babel@​3.0.61001006488100
Added@​babel/​plugin-transform-property-literals@​7.22.51001006489100
Added@​babel/​plugin-transform-member-expression-literals@​7.22.51001006489100
Added@​babel/​plugin-transform-json-strings@​7.22.111001006589100
Added@​babel/​plugin-transform-dynamic-import@​7.22.111001006689100
Added@​babel/​plugin-proposal-private-property-in-object@​7.21.0-placeholder-for-preset-env.21001006681100
Added@​babel/​plugin-transform-object-super@​7.22.51001006689100
Added@​babel/​plugin-bugfix-safari-id-destructuring-collision-in-function-expression@​7.22.151001006789100
Added@​babel/​plugin-transform-block-scoped-functions@​7.22.51001006789100
Added@​babel/​plugin-transform-react-pure-annotations@​7.22.51001006789100
Added@​tanstack/​query-async-storage-persister@​5.85.51001006797100
Added@​babel/​plugin-transform-export-namespace-from@​7.22.111001006789100
Added@​types/​gh-pages@​6.1.0961006876100
Added@​babel/​helper-hoist-variables@​7.22.51001006881100
Added@​tanstack/​react-query-persist-client@​5.56.21001006897100
Added@​babel/​plugin-transform-duplicate-keys@​7.22.51001006889100
Added@​babel/​plugin-transform-typeof-symbol@​7.22.51001006889100
Added@​babel/​plugin-bugfix-v8-spread-parameters-in-optional-chaining@​7.22.151001006889100
Added@​babel/​plugin-transform-class-static-block@​7.22.111001006894100
See 56 more rows in the dashboard

View full report

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

.filter(network => network?.imageId)
.slice(0, 5)
.map(AssetUtil.getNetworkImage)
.map(network => AssetUtil.getNetworkImage(network, AssetController.state.networkImages))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Reactive State Access Issue

The imagesArray map function directly accesses AssetController.state.networkImages instead of using the reactive networkImages snapshot. This bypasses reactivity and could lead to stale network images being displayed if the state updates.

Fix in Cursor Fix in Web

@ignaciosantise ignaciosantise merged commit c8b31c2 into main Aug 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants