Skip to content

Conversation

@ignaciosantise
Copy link
Collaborator

@ignaciosantise ignaciosantise commented Jul 1, 2025

This pull request includes various changes across multiple files, focusing on dependency updates, configuration improvements, and new test coverage. The key updates include consolidating dependency management, enhancing workflows, and adding comprehensive tests for FetchUtil.

Dependency and Configuration Updates:

  • Updated valtio dependency to version 1.13.2 in packages/core/package.json and adjusted imports in EnsController.ts and EventsController.ts to align with the new version. [1] [2] [3]
  • Extended .prettierignore to include additional directories and files such as .github/, .changeset/, and scripts/.
  • Added a new ESLint rule to disable dot-notation checks.

Workflow Enhancements:

  • Introduced verify and e2e jobs in the GitHub Actions workflow, ensuring they run before the release job.

Changeset and Versioning:

  • Simplified dependency ignore rules in .changeset/config.json by using a wildcard pattern (@apps/*).
  • Updated @changesets/cli and @changesets/changelog-github to newer versions in package.json.

Author Field Standardization:

  • Updated the author field in multiple package.json files to use a Discord link instead of an email address. [1] [2] [3] [4] [5] [6]

New Test Coverage:

  • Added comprehensive unit tests for the FetchUtil class, covering various scenarios for URL construction and query parameter handling.

ignaciosantise and others added 21 commits March 28, 2025 12:19
Replace author field from 'Reown <support@reown.com> (https://reown.com)'
to 'Reown (https://discord.gg/reown)' across all packages.

Updated 14 package.json files:
- packages/auth-ethers/package.json
- packages/auth-wagmi/package.json
- packages/coinbase-ethers/package.json
- packages/coinbase-wagmi/package.json
- packages/common/package.json
- packages/core/package.json
- packages/ethers/package.json
- packages/ethers5/package.json
- packages/scaffold-utils/package.json
- packages/scaffold/package.json
- packages/siwe/package.json
- packages/ui/package.json
- packages/wagmi/package.json
- packages/wallet/package.json

Co-Authored-By: Ben Kremer <ben@reown.com>
…-field-to-discord

Update author field in package.json files to use Discord link
Co-Authored-By: Ben Kremer <ben@reown.com>
…e.json

The root package.json requires the 'name' property for Turbo workspace
functionality. Removing it caused build failures in CI. This commit
restores the name property while keeping the package marked as private.

Co-Authored-By: Ben Kremer <ben@reown.com>
…ents

- Root package.json has both 'private': true and 'name' properties
- Testing confirmed that Turbo workspace functionality works without the name property
- All build, lint, and prettier commands pass successfully without it

Co-Authored-By: Ben Kremer <ben@reown.com>
- Remove outdated workspace reference after removing name property from root package.json
- Addresses GitHub comment from bkrem to update lockfile for CI fixes

Co-Authored-By: Ben Kremer <ben@reown.com>
Co-Authored-By: Ben Kremer <ben@reown.com>
…rom-private-packages

Remove name property from private package.json files
chore: bump valtio to 1.13.2 and remove vanilla imports
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: df7b5b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@reown/appkit-core-react-native Patch
@reown/appkit-ui-react-native Patch
@reown/appkit-common-react-native Patch
@reown/appkit-wallet-react-native Patch
@reown/appkit-scaffold-utils-react-native Patch
@reown/appkit-scaffold-react-native Patch
@reown/appkit-siwe-react-native Patch
@reown/appkit-wagmi-react-native Patch
@reown/appkit-coinbase-wagmi-react-native Patch
@reown/appkit-auth-wagmi-react-native Patch
@reown/appkit-auth-ethers-react-native Patch
@reown/appkit-coinbase-ethers-react-native Patch
@reown/appkit-ethers5-react-native Patch
@reown/appkit-ethers-react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@socket-security
Copy link

socket-security bot commented Jul 1, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​changesets/​should-skip-package@​0.1.0 ⏵ 0.1.2100 +11005983 -2100
Updated@​changesets/​changelog-git@​0.2.0 ⏵ 0.2.11001006083100
Updated@​changesets/​changelog-github@​0.5.0 ⏵ 0.5.1100 +11006583100
Updated@​changesets/​read@​0.6.0 ⏵ 0.6.599 +110071 +185100
Updated@​changesets/​git@​3.0.0 ⏵ 3.0.4100 +110072 +185100
Updated@​changesets/​get-dependents-graph@​2.1.1 ⏵ 2.1.3100 +110072 +184100
Updated@​changesets/​types@​6.0.0 ⏵ 6.1.0100 +110072 +183100
Updated@​changesets/​get-release-plan@​4.0.3 ⏵ 4.0.13100 +110073 +393 -1100
Updated@​types/​semver@​7.5.3 ⏵ 7.5.01001007377100
Updatedspawndamnit@​2.0.0 ⏵ 3.0.11001007477100
Updated@​changesets/​config@​3.0.2 ⏵ 3.1.199 +110076 +185100
Addedchromium-edge-launcher@​0.2.09610010076100
Updatedlocate-path@​6.0.0 ⏵ 5.0.0100 +1100100 +176100
Added@​isaacs/​ttlcache@​1.4.110010010076100
Updatedfind-up@​5.0.0 ⏵ 4.1.010010010076100
Updatedhuman-id@​1.0.2 ⏵ 4.1.1100100100 +2776100
Updated@​changesets/​pre@​2.0.0 ⏵ 2.0.2100 +110077 +183100
Updated@​changesets/​logger@​0.1.0 ⏵ 0.1.11001007982100
Addedselfsigned@​2.4.11001009579100
Updatedpkg-dir@​4.2.0 ⏵ 3.0.010010079 -782100
Updated@​changesets/​apply-release-plan@​7.0.4 ⏵ 7.0.1299 +110079 +187100
Updated@​changesets/​write@​0.3.1 ⏵ 0.4.0100 +110080 +183 -2100
Updated@​changesets/​parse@​0.4.0 ⏵ 0.4.110010081 +183100
Updatedcolor-convert@​1.9.3 ⏵ 2.0.11001009081100
Updated@​changesets/​assemble-release-plan@​6.0.3 ⏵ 6.0.9100 +110084 +192 -1100
Addedserve-static@​1.16.210010010084100
Addedchrome-launcher@​0.15.29610010084100
Added@​react-native/​debugger-frontend@​0.76.71001008597100
Addedquansync@​0.2.1010010010086100
Addedpackage-manager-detector@​0.2.1110010010090100
Updated@​changesets/​cli@​2.27.7 ⏵ 2.29.597 +1100100 +194100

View full report

cursor[bot]

This comment was marked as outdated.

fix: disable layout animations on ios new arch projects
cursor[bot]

This comment was marked as outdated.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2025

@ignaciosantise ignaciosantise merged commit e665747 into main Jul 3, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants