Support for actively maintained PHP, Laravel, K8s versions#474
Closed
ryancco wants to merge 5 commits intorenoki-co:masterfrom
Closed
Support for actively maintained PHP, Laravel, K8s versions#474ryancco wants to merge 5 commits intorenoki-co:masterfrom
ryancco wants to merge 5 commits intorenoki-co:masterfrom
Conversation
ryancco
commented
Sep 19, 2025
| * @dataProvider environmentVariableContextProvider | ||
| */ | ||
| public function test_from_environment_variable(string $context = null, string $expectedDomain) | ||
| #[DataProvider('environmentVariableContextProvider')] |
Author
There was a problem hiding this comment.
This was a requirement with latest stable PHPUnit
| @@ -1,16 +1,23 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" backupGlobals="false" backupStaticAttributes="false" colors="true" verbose="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"> | |||
Author
There was a problem hiding this comment.
Regenerated the configuration with --generate-configuration and modified it to match the behavior of the previous as closely as possible. This was necessary due to it being too far out of date to migrate with --migrate-configuration.
| env: | ||
| TEST_TOKEN: some-token | ||
| TEST_CERT: c29tZS1jZXJ0Cg== | ||
| TEST_NAMESPACE: some-namespace |
Author
There was a problem hiding this comment.
The changes in this step are subjective and admittedly not necessary. Happy to change them back if you'd like. Though they're functionally equivalent.
ryancco
changed the title
ryancco
changed the title
SCIF
reviewed
Nov 27, 2025
|
@rennokki , any chance to merge this? The package is actually far from up to date so would be great to have this merged |
Contributor
|
I have a branch here where I've got most of this and some other additions: |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't address a few deprecations as of PHP 8.4 regarding implicitly nullable types but am happy to do so as a follow-up if we can get this merged. They're non-breaking until PHP 9.x.
All test passing here.
Here's my thinking for dropping support for older versions:
I'm happy to discuss alternative options if this is too restrictive and we either don't want to tag a new major release or want to support against legacy versions.