feat: add --compute flag for gpu encoding#57
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
--compute <auto|cpu|gpu>flag torb ffmpeg, exposing the now-live GPU/compute routing option of the FFmpeg job type.auto(default behavior when omitted) — server auto-routes NVENC/CUDA commands to GPUgpu— forces GPU (NVENC on NVIDIA L4, Pro plan)cpu— forces CPUChanges
--computein the global-flag loop; it takes a value (added to theglobalFlagsWithValueset so it's stripped from the FFmpeg args passed through to the executor).auto|cpu|gpu; an invalid value errors with a clear message and exits2, matching the existing flag-error convention.computein the submitparamsonly when the user passed it, so default submissions are byte-identical to before.--compute <mode> Run on cpu or gpu hardware (auto, cpu, gpu; gpu needs Pro).Tests
Four new cases in
ffmpeg-command.test.ts:--compute gpuputscompute: "gpu"in params;auto/cpuaccepted; invalid values rejected; omitting the flag leavescomputeout of params.Verification
pnpm typecheck— cleanpnpm test— 134 pass / 0 fail