Conversation
Contributor
dcvz
commented
Dec 18, 2025
dcvz
commented
- Fixes examples so they work on all platforms (D3D12, Vulkan, Metal) without any validation issues
- Fixes bug in Vulkan where setName is not using right type for buffer
- Fixes bug in Vulkan where the swapchain size is not exactly correct as what's available for drawing
- Fixes bug in D3D12 where constant buffers need to be aligned
squidbus
reviewed
Dec 18, 2025
Contributor
squidbus
left a comment
squidbus
left a comment
There was a problem hiding this comment.
Seems alright but are the shader utility changes from the RT PR meant to be here? Seems like some of the decisions there should be reviewed as part of RT rather than separately here.
This comment has been minimized.
This comment has been minimized.
squidbus
approved these changes
Dec 18, 2025
dcvz
force-pushed
the
chore/bug-fixes
branch
from
d44e63e to
c99ee11
Compare
DarioSamo
force-pushed
the
chore/bug-fixes
branch
from
283283b to
902070f
Compare
Contributor
|
It all looks good to me, what remains to be addressed is just to make it easier to set up SDL2 on Windows. It should either explicitly request the path of where the library is or auto-download it in a similar way like what it does with DXC if it builds the example under Windows. |
DarioSamo
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.