Expose the checkpoint and some task/frame members#26
Open
Trolldemorted wants to merge 1 commit intorems-project:masterfrom
Open
Expose the checkpoint and some task/frame members#26Trolldemorted wants to merge 1 commit intorems-project:masterfrom
Trolldemorted wants to merge 1 commit intorems-project:masterfrom
Conversation
Trolldemorted
changed the title
Collaborator
|
I wonder if it would be better to expose these as getter/setter functions rather than public fields to keep the datatypes abstract? For trace it might be best to derive the Iterator trait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am currently trying to mitigate #21 by letting isla only execute one cycle and examining the trace (translating the symbols into an acyclic graph and back). Unfortunately the fields aren't public, so I reduced my diff to the neccessary changes for you to consider merging.
I also had to bump the z3-sys version because I had to fix a bug there.