[CN-exec] Fix missing instrumentation for ghost arguments under labels and loops#499
Merged
dimecon merged 18 commits intorems-project:mainfrom Mar 12, 2026
Merged
Conversation
But can we replace foo with something that already exists, like welltyped?
dimecon
changed the title
dimecon
changed the title
rbanerjee20
reviewed
Mar 11, 2026
Contributor
rbanerjee20
left a comment
rbanerjee20
left a comment
There was a problem hiding this comment.
Mostly looks good. I've included some questions on whether changes to the parts of the codebase relating to label inlining are still necessary, and one small comment on the new test cases.
rbanerjee20
approved these changes
Mar 11, 2026
Contributor
rbanerjee20
left a comment
rbanerjee20
left a comment
There was a problem hiding this comment.
Looks good to me - feel free to merge once CI is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #452. The analysis of mucore programs for the purpose of instrumenting ghost arguments was incomplete. To complete it for non-loop labels, the core-to-mucore label normalisation is updated to preserve the label body.