Remove unused set fe_tax_sub36#2333
Draft
ricardarosemann wants to merge 1 commit intoremindmodel:developfrom
Draft
Remove unused set fe_tax_sub36#2333ricardarosemann wants to merge 1 commit intoremindmodel:developfrom
ricardarosemann wants to merge 1 commit intoremindmodel:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Remove the set
fe_tax_sub36from the buildings module as it is no longer used: All entries in this set are written tofe_tax_sub_sbi. But this set is only called withfe_tax_sub_sbi("fehos", <input>)whereasfe_tax_sub36contains no elements with "fehos" as the first entry.Moreover, no other set elements are ever added to
fe_tax_sub_sbi, meaning thatfe_tax_sub_sbi("fehos", <input>)is empty. This issue should be addressed separately by cleaning up the11_aerosolsmodule, wherefe_tax_sub_sbiis called, and will not directly be addressed in this PR. @laurinks @gunnar-pikType of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)