Skip to content

Remove duplicate set names#2332

Merged
fbenke-pik merged 5 commits intoremindmodel:developfrom
fbenke-pik:sets
Apr 30, 2026
Merged

Remove duplicate set names#2332
fbenke-pik merged 5 commits intoremindmodel:developfrom
fbenke-pik:sets

Conversation

@fbenke-pik
Copy link
Copy Markdown
Contributor

@fbenke-pik fbenke-pik commented Apr 14, 2026

Purpose of this PR

Resolve conflicts due to duplicate set names used in more than one context

  • rename module 33_CDR to 33_carbonRemoval, as cdr is reserved for the technology
  • rename module 39_CCU to 39_carbonUtilization, as ccu is reserved for the technology
  • rename set item pri to prim, as pri is reserved to Puerto Rico

See also https://github.com/remindmodel/development_issues/issues/689

Type of change

Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.

Parts concerned

  • ☑️ GAMS Code
  • ◻️ R-scripts
  • ◻️ Documentation (GAMS incode documentation, comments, tutorials)
  • ◻️ Input data / CES parameters
  • ◻️ Tests, CI/CD (continuous integration/deployment)
  • ◻️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
  • ◻️ Other (please give a description)

Impact

  • ◻️ Bug fix
  • ☑️ Refactoring
  • ◻️ New feature
  • ◻️ Change of parameter values or input data (including CES parameters)
  • ☑️ Minor change (default scenarios show only small differences)
  • ◻️ Fundamental change of results of default scenarios

Checklist

Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge
.

  • I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
  • I adjusted the reporting in remind2 if and where it was needed
  • I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
  • My code follows the coding etiquette
  • I explained my changes within the PR, particularly in hard-to-understand areas
  • I checked that the in-code documentation is up-to-date
  • I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
  • I updated the CHANGELOG.md correctly (added, changed, fixed, removed, input data/calibration)

Further information (optional)

  • Runs with these changes are here: p/tmp/benke/model/remind_sets
image

@fbenke-pik fbenke-pik changed the title Sets Remove duplicate set names Apr 14, 2026
@fbenke-pik fbenke-pik marked this pull request as ready for review April 29, 2026 14:01
Copy link
Copy Markdown
Contributor

@JakobBD JakobBD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Copy link
Copy Markdown
Member

@LaviniaBaumstark LaviniaBaumstark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new input data are needed due to the renamings, right?

@fbenke-pik
Copy link
Copy Markdown
Contributor Author

no new input data are needed due to the renamings, right?

No, everything works as is.

@fbenke-pik fbenke-pik merged commit cd73e30 into remindmodel:develop Apr 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants