Improve lst file2#1254
Draft
robertpietzcker wants to merge 11 commits intoremindmodel:developfrom
Draft
Conversation
Member
|
what is the status of thsi PR? will you continue working on it? |
Member
|
How to procced with this PR @robertpietzcker @robinhasse ? |
Contributor
|
I don't feel qualified to judge the changes in module 47. But some changes in the building module seem wrong to me. Are the additional lines around |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Improve convergence of p47_implicitQttyTargetTax:
Type of change
Checklist:
FAIL 0in the output ofmake test)Further information (optional):