fix: subscribe before broadcast in connectWithBunkerUrl to avoid miss…

packages/ndk/lib/data_layer/repositories/signers/nip46_event_signer.dart

@@ -48,13 +48,11 @@ class Nip46EventSigner implements EventSigner {
   Future<void> listenRelays() async {
     subscription = requests.subscription(
       explicitRelays: connection.relays,
-      filters: [
-        Filter(
-          authors: [connection.remotePubkey],
-          kinds: [BunkerRequest.kKind],
-          pTags: [localEventSigner.publicKey],
-        ),
-      ],
+      filter: Filter(
+        authors: [connection.remotePubkey],
+        kinds: [BunkerRequest.kKind],
+        pTags: [localEventSigner.publicKey],
+      ),
     );
 
     subscription!.stream.listen(onEvent);

packages/ndk/lib/domain_layer/usecases/bunkers/bunkers.dart

@@ -75,21 +75,25 @@ class Bunkers {
     );
 
     final signedEvent = await localEventSigner.sign(requestEvent);
-    final broadcastRes =
-        _broadcast.broadcast(nostrEvent: signedEvent, specificRelays: relays);
-    await broadcastRes.broadcastDoneFuture;
 
+    // Subscribe BEFORE broadcasting to avoid missing the response,
+    // since NIP-46 uses ephemeral events (kind 24133)
     final subscription = _requests.subscription(
       explicitRelays: relays,
-      filters: [
-        Filter(
-          authors: [remotePubkey],
-          kinds: [BunkerRequest.kKind],
-          pTags: [localEventSigner.publicKey],
-          since: someTimeAgo(),
-        ),
-      ],
+      filter: Filter(
+        authors: [remotePubkey],
+        kinds: [BunkerRequest.kKind],
+        pTags: [localEventSigner.publicKey],
+        since: someTimeAgo(),
+      ),
+    );
+
+    final broadcastRes = _broadcast.broadcast(
+      nostrEvent: signedEvent,
+      specificRelays: relays,
     );
+    await broadcastRes.broadcastDoneFuture;
+
     BunkerConnection? result;
 
     await for (final event in subscription.stream
@@ -144,13 +148,11 @@ class Bunkers {
 
     final subscription = _requests.subscription(
       explicitRelays: relays,
-      filters: [
-        Filter(
-          kinds: [BunkerRequest.kKind],
-          pTags: [localEventSigner.publicKey],
-          since: someTimeAgo(),
-        ),
-      ],
+      filter: Filter(
+        kinds: [BunkerRequest.kKind],
+        pTags: [localEventSigner.publicKey],
+        since: someTimeAgo(),
+      ),
     );
     BunkerConnection? result;
 

packages/ndk/test/signers/nip46_event_signer_test.dart

@@ -46,6 +46,7 @@ void main() {
 
     tearDown(() async {
       signer.dispose();
+      await ndk.destroy();
       await mockRelay.stopServer();
     });
 
@@ -121,10 +122,10 @@ void main() {
         content: 'Test event via bunker URL',
       );
 
-      await bunkerSigner.sign(testEvent);
+      final signedTestEvent = await bunkerSigner.sign(testEvent);
 
-      expect(testEvent.id, isNotNull);
-      expect(testEvent.sig, isNotNull);
+      expect(signedTestEvent.id, isNotNull);
+      expect(signedTestEvent.sig, isNotNull);
 
       bunkerSigner.dispose();
     });
@@ -169,10 +170,10 @@ void main() {
         content: 'Test event via loginWithBunkerUrl',
       );
 
-      await accounts.sign(testEvent);
+      final signedTestEvent = await accounts.sign(testEvent);
 
-      expect(testEvent.id, isNotNull);
-      expect(testEvent.sig, isNotNull);
+      expect(signedTestEvent.id, isNotNull);
+      expect(signedTestEvent.sig, isNotNull);
 
       // Cleanup
       accounts.logout();
@@ -217,10 +218,10 @@ void main() {
         content: 'Test event via loginWithBunkerConnection',
       );
 
-      await accounts.sign(testEvent);
+      final signedTestEvent = await accounts.sign(testEvent);
 
-      expect(testEvent.id, isNotNull);
-      expect(testEvent.sig, isNotNull);
+      expect(signedTestEvent.id, isNotNull);
+      expect(signedTestEvent.sig, isNotNull);
 
       // Cleanup
       accounts.logout();
@@ -353,5 +354,5 @@ void main() {
       final response = await signer.ping();
       expect(response, equals('pong'));
     });
-  }, skip: true);
+  });
 }