Skip to content

Conversation

@nogringo
Copy link
Collaborator

ndk.nip05.of("pubkey") never read from cache. Do we need update cache managers with a method to get the pubkey from the nip05 idetifier ?

Close #208

@nogringo nogringo self-assigned this Jan 24, 2026
@nogringo nogringo requested review from 1-leo and frnandu January 24, 2026 12:17
@nogringo nogringo requested a review from 1-leo January 24, 2026 18:50
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.47%. Comparing base (07dfd2c) to head (c22a1e4).
⚠️ Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
packages/ndk/lib/presentation_layer/ndk.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   72.30%   72.47%   +0.17%     
==========================================
  Files         144      144              
  Lines        5585     5620      +35     
==========================================
+ Hits         4038     4073      +35     
  Misses       1547     1547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple nip05 request from validating

4 participants