-
Notifications
You must be signed in to change notification settings - Fork 5
Feat blossom stream file from disk #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 72.30% 72.83% +0.52%
==========================================
Files 144 146 +2
Lines 5585 5808 +223
==========================================
+ Hits 4038 4230 +192
- Misses 1547 1578 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is it possible to cancel an upload ? |
for uploadFromFile yes, you can just cancel the returned stream |
|
frnandu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
fixes: #211
dependent on: #332 (merge before)
This PR introduces file streaming so large files are not loaded entirely into memory.
Its non-breaking, old method signatures have not been altered.
Both the files usecase and blossom usecase have the new streaming methods.