Add high priority fields to beginning of JSON object when json format#322
Closed
Fire-Dragon-DoL wants to merge 1 commit intoreidmorrison:masterfrom
Closed
Conversation
Fire-Dragon-DoL
force-pushed
the
francesco/timestamp-level-message-first
branch
from
af9b575 to
f116a6d
Compare
Owner
|
Can you merge the latest master to resolve the conflicts and I will merge the PR? |
Fire-Dragon-DoL
force-pushed
the
francesco/timestamp-level-message-first
branch
from
f116a6d to
8997fb0
Compare
Author
Thank you @reidmorrison , I rebased on master, it is ready for merge |
Author
|
Hi @reidmorrison , any chance this could be merged? It's our main blocker in adopting semantic_logger right now. There is a workaround, but it's a lot more code than this, I'd love to keep the complexity low |
Contributor
|
@Fire-Dragon-DoL I think it needs another rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
N/A
Changelog
Pull requests will not be accepted without a description of this change under the
[unreleased]sectionin the file
CHANGELOG.Description of changes
This PR moves the timestamp, level, level_index and message to the beginning of the JSON object.
This was a request by our DevOps team so that in case something is wrong with the JSON output and something is being "mangled" at the end of the log line, it is possible to extract timestamp, level and message from the information using regex or in general, simple tools.
This change shouldn't break anything since order of JSON shouldn't matter for any programmatic tools, but it does change for humans.
Would you be open to this kind of change?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.