Skip to content

iddata refactoring#48

Open
matthewcornell wants to merge 3 commits into
mainfrom
mc/idmodels-iddata-refactor
Open

iddata refactoring#48
matthewcornell wants to merge 3 commits into
mainfrom
mc/idmodels-iddata-refactor

Conversation

@matthewcornell
Copy link
Copy Markdown
Member

implementation of design4.md

  • updated to latest idmodels commit hash
  • added build-dev.sh and Dockerfile.dev for local dev

…ld-dev.sh and Dockerfile.dev for local development
@matthewcornell matthewcornell changed the title iddata refactoring. updated to latest idmodels commit hash iddata refactoring Apr 28, 2026
Copy link
Copy Markdown
Contributor

@lshandross lshandross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a handful of comments here, which are mainly:

  1. The code was implemented or formatted in different ways for different models, and we need to select one way for standardization.
  2. There is some mild duplication that we can likely get rid of
  3. The help parameter describing the various options was removed, but I think we should keep it

Comment thread covid_ar6_pooled/main.py Outdated
Comment thread covid_gbqr/main.py Outdated
Comment thread flu_flusion/main.py Outdated
Comment thread covid_ar6_pooled/main.py Outdated
Comment thread flu_flusion/main.py Outdated
matthewcornell and others added 2 commits May 13, 2026 10:56
…ig, updated deps

- Add help= text to all click options across all four model runners
- Standardize states/q_levels/q_labels formatting in covid_ar6_pooled to match other models
- Collapse duplicate ar6_run_config + gbqr_run_config in flu_flusion into single run_config
- Use two-line model instantiation pattern in flu_flusion (model = ...; model.run(...))
- Update iddata dependency hash to af9b0a1b (version 0.2.0) in all requirements files
- Update idmodels dependency hash to 8ed3d9d in all requirements files
…or branch tips

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants