iddata refactoring#25
Open
matthewcornell wants to merge 11 commits into
Open
Conversation
lshandross
requested changes
May 6, 2026
Contributor
lshandross
left a comment
lshandross
left a comment
There was a problem hiding this comment.
I'm having trouble adding more comments to my review, so I'm submitting it as-is with some overall/remaining thoughts:
- A lot of inline comments and function descriptions were removed, perhaps in an attempt to cleanup the code. Personally, I'd like to keep them since the comments improve the human readability of the code
- Claude has removed various lines of code throughout idmodels in its refactor of the codebase, particularly in areas where it made large changes like the directional wave features. I'd like to know if the codebase is still doing the same thing as the original code
- I'd like to chat with Claude to determine if the tests it added for the new features and transforms classes are sufficient
| return model_config | ||
|
|
||
|
|
||
| def create_test_sarix_run_config(ref_date, states, hsas, tmp_path): |
Contributor
There was a problem hiding this comment.
As mentioned previously, we should combine the two helper functions to create testing run configs
…ove dead SARIX holiday code, restore DirectionalWaveFeature docstring; add unit tests for HolidayFeature, TaylorFeature, RollingMeanFeature, CenterScaleTransform, and edge cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
….lock Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lshandross
reviewed
May 14, 2026
lshandross
reviewed
May 18, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without explicit known-first-party, ruff classified idmodels inconsistently across environments, causing removed blank lines locally that CI expected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… into conftest Restores `# patch the _np_percentile()...` and `# only forecast for N ...` comments dropped during the iddata refactor. Also extracts the identical `create_test_gbqr_run_config` / `create_test_sarix_run_config` helpers into a single `make_run_config` factory fixture in tests/integration/conftest.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lshandross
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation of design4.md