Feat. .Desktop Actions#109
Open
harshaaaaaaaaaa wants to merge 6 commits intoregolith-linux:mainfrom
Open
Conversation
Contributor
|
Can you resolve the conflicts? |
Contributor
|
Also please un-draft it if it's ready... |
Contributor
Author
Logs shows, it's docker's issue, as the image is unable to fetch details required. |
Contributor
No like, rebase the branch on top of main. Not talking about the CI failure. Had seen already seen the logs for that. |
SoumyaRanjanPatnaik
requested changes
Jul 20, 2025
Contributor
SoumyaRanjanPatnaik
left a comment
SoumyaRanjanPatnaik
left a comment
There was a problem hiding this comment.
Preliminary review. Haven't looked at the DesktopAppPage.vala file yet. LMK if you have any queries. Will do a more thorough review later.
harshaaaaaaaaaa
force-pushed
the
desktop-actions
branch
from
f379a1f to
2b8ba1e
Compare
- Fix incorrect UP/DOWN key code constants (65362/65364 swapped) - Improve cursor positioning after paste operations - Enhance keyboard navigation handling for dialog pages - Add proper Alt+D key event delegation to active pages - Improve dialog resizing for both X11 and Wayland - Add get_wm_name() method to SessionController interface
- Add fuzzy_match_score() function for string matching - Add character sequence matching - Include fuzzy_match() helper with configurable threshold - Replace old compare_desktop_apps sorting logic - Improve search accuracy for application names and keywords
- Implement desktop actions popover accessible via Alt+D - Add favorites system with Ctrl+S toggle and star indicators - Support .desktop file actions and generic actions - Include workspace management for next workspace launches - Integrate fuzzy search with favorites prioritization - Add GSettings storage for favorite apps list - Enhance app sorting to prioritize favorites over launch history
harshaaaaaaaaaa
force-pushed
the
desktop-actions
branch
from
822c815 to
a7772c3
Compare
- Create standalone HelpPage class implementing DialogPage interface - Add comprehensive keybinding documentation with TreeView - Remove inline help implementation from DialogWindow
harshaaaaaaaaaa
force-pushed
the
desktop-actions
branch
from
a7772c3 to
b9ef838
Compare
SoumyaRanjanPatnaik
requested changes
Aug 26, 2025
Comment on lines
+318
to
+321
| case "clipboard": | ||
| dialog_pages[0] = new ClipboardPage (); | ||
| dialog_pages[0].initialize.begin(settings, arg_map, entry, this, this.wm_name, this.is_wayland); | ||
| break; |
Contributor
There was a problem hiding this comment.
Remove clipboard page.
Comment on lines
+351
to
+352
| dialog_pages[6] = new ClipboardPage (); | ||
| dialog_pages[6].initialize.begin(settings, arg_map, entry, this, this.wm_name, this.is_wayland); |
Contributor
There was a problem hiding this comment.
Remove clipboard page
| */ | ||
| private int create_all_pages(HashTable<string, string ?> arg_map, string focus_page, ref uint start_page) { | ||
| int page_count = 6; | ||
| int page_count = 7; // increased for clipboard page |
Contributor
There was a problem hiding this comment.
Should be 6 without clipboard page.
| return; | ||
| } | ||
|
|
||
| if (dialog_pages[page_num] is HelpPage) { // On help page |
Contributor
There was a problem hiding this comment.
HelpPage doesn't exist at this point.
Comment on lines
+123
to
+127
| if (pos > 0 && (s_lower[pos - 1] == ' ' || s_lower[pos - 1] == '-' || s_lower[pos - 1] == '_')) { | ||
| return 85 + int.min(10, 10 * pattern.length / source.length); | ||
| } | ||
| // Regular substring match - penalize based on position | ||
| return 75 + int.min(10, 15 * pattern.length / source.length) - int.min(10, pos / 3); |
Contributor
There was a problem hiding this comment.
Refer to my comment on the old commit. See if you can generalize these cases and make the formula more readable. Also is there a specific reason for prioritizing cases with _,- or space?
| // Check for acronym match (first letters of words) | ||
| if (check_acronym_match(s_lower, p_lower)) { | ||
| return 70 + int.min(15, 20 * pattern.length / source.length); | ||
| } |
Contributor
There was a problem hiding this comment.
You can skip this check also. We want to minimize the number of checks we do.
Comment on lines
+153
to
+162
| // Bonus for matching at the start | ||
| if (j == 0) { | ||
| start_bonus += 10; | ||
| } | ||
|
|
||
| // Bonus for matching at word boundaries | ||
| if (j > 0 && (s_lower[j - 1] == ' ' || s_lower[j - 1] == '-' || s_lower[j - 1] == '_')) { | ||
| word_boundary_bonus += 5; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Again not sure how this helps.
harshaaaaaaaaaa
force-pushed
the
desktop-actions
branch
from
9ec7749 to
d6308c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added .desktop actions popover.
Works with :
Screencast_20250607_183046.mov
Added libNotify for notification (Added to Favourite)
TO DO