fix: send required GitHub API headers#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the gateway OAuth callback path by adding GitHub REST API headers to user-detail requests and adding coverage to verify those headers are sent.
Changes:
- Adds shared GitHub API headers for
/userand/user/emailsfetches. - Logs bounded GitHub
/userfailure details for diagnosability. - Adds an OAuth callback test that verifies GitHub API request headers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/gateway/src/auth.ts |
Adds GitHub API headers and failure logging in the OAuth callback user fetch path. |
apps/gateway/test/index.spec.ts |
Adds a mock OAuth callback test covering GitHub API headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agent, to OAuth user detail requests./userfailure details to make future OAuth callback 502s diagnosable.Verification
pnpm testinapps/gatewaypnpm buildinapps/gatewayCreated with Constructor