Mobile app + vendored protocol (core-loop UI, EAS, runbooks)#1
Closed
Quantumlyy wants to merge 1 commit into
Closed
Mobile app + vendored protocol (core-loop UI, EAS, runbooks)#1Quantumlyy wants to merge 1 commit into
Quantumlyy wants to merge 1 commit into
Conversation
Expo SDK 55 RN app: mock SessionGateway seam, native UIKit nav, kv-store profiles, EAS Update/TestFlight/Insights config, runbooks. Vendored protocol @ a7b968f + scripts/vendor-protocol.sh. Squashed snapshot of build/mobile-ui (app+protocol scope). Verified: tsc clean + Metro iOS bundle. Backend mocked until ColeMurray/background-agents@a7b968f deploys.
Member
Author
|
Closing — created in error (broken path split, mass-deletion). origin main/build branches untouched; will recreate cleanly. |
There was a problem hiding this comment.
Pull request overview
As currently represented by the diff, this PR removes the Expo mobile app workspace (apps/mobile) and the vendored protocol workspace (packages/protocol), including their configs and starter UI/template files. This conflicts with the PR title/description, which state the mobile app + vendored protocol are being added and EAS-ready.
Changes:
- Delete
packages/protocol/package.json(removes the protocol workspace package definition). - Delete the entire
apps/mobileExpo app scaffold/config (package.json, app.json, tsconfig, Metro config, .gitignore, starter screens/components, and related tooling/docs). - Remove various editor/agent config files under
apps/mobile(.vscode/, .claude/, AGENTS.md/CLAUDE.md).
Reviewed changes
Copilot reviewed 33 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/protocol/package.json | Deletes protocol workspace package definition |
| apps/mobile/tsconfig.json | Deletes mobile TypeScript config |
| apps/mobile/src/hooks/use-theme.ts | Removes Expo template theme hook |
| apps/mobile/src/hooks/use-color-scheme.web.ts | Removes Expo template color scheme hook (web) |
| apps/mobile/src/hooks/use-color-scheme.ts | Removes re-export of RN useColorScheme |
| apps/mobile/src/global.css | Deletes global CSS variables for web |
| apps/mobile/src/constants/theme.ts | Deletes template theme constants (colors/fonts/spacing) |
| apps/mobile/src/components/web-badge.tsx | Deletes template web badge component |
| apps/mobile/src/components/ui/collapsible.tsx | Deletes template collapsible UI component |
| apps/mobile/src/components/themed-view.tsx | Deletes template themed view wrapper |
| apps/mobile/src/components/themed-text.tsx | Deletes template themed text wrapper |
| apps/mobile/src/components/hint-row.tsx | Deletes template hint row component |
| apps/mobile/src/components/external-link.tsx | Deletes template external link wrapper |
| apps/mobile/src/components/app-tabs.web.tsx | Deletes template web tabs implementation |
| apps/mobile/src/components/app-tabs.tsx | Deletes template native tabs implementation |
| apps/mobile/src/components/animated-icon.web.tsx | Deletes template animated icon (web) |
| apps/mobile/src/components/animated-icon.tsx | Deletes template animated icon (native) |
| apps/mobile/src/components/animated-icon.module.css | Deletes CSS module for animated icon background |
| apps/mobile/src/app/index.tsx | Deletes template Home screen |
| apps/mobile/src/app/explore.tsx | Deletes template Explore screen |
| apps/mobile/src/app/_layout.tsx | Deletes template router layout |
| apps/mobile/scripts/reset-project.js | Deletes template reset-project script |
| apps/mobile/README.md | Deletes template README |
| apps/mobile/package.json | Deletes mobile workspace package definition |
| apps/mobile/metro.config.js | Deletes Expo monorepo Metro config |
| apps/mobile/CLAUDE.md | Deletes Claude pointer file |
| apps/mobile/assets/expo.icon/icon.json | Deletes Expo icon asset config |
| apps/mobile/assets/expo.icon/Assets/expo-symbol 2.svg | Deletes Expo icon SVG asset |
| apps/mobile/app.json | Deletes Expo app configuration (incl. EAS projectId previously) |
| apps/mobile/AGENTS.md | Deletes mobile agent guidance doc |
| apps/mobile/.vscode/settings.json | Deletes workspace VS Code settings |
| apps/mobile/.vscode/extensions.json | Deletes workspace VS Code extension recommendations |
| apps/mobile/.gitignore | Deletes mobile-specific ignore rules |
| apps/mobile/.claude/settings.json | Deletes Claude settings for mobile workspace |
Comments suppressed due to low confidence (5)
packages/protocol/package.json:1
- This change deletes the
packages/protocolworkspace package (package.json removed), but the PR description says a vendored protocol package is being added/pinned. If the protocol is still required, keeppackages/protocol/package.json(and the package directory) in the PR; if it’s intentionally removed, update the PR description/docs and ensure no workspace/lockfile references remain.
apps/mobile/package.json:1 - This PR deletes the Expo mobile workspace (
apps/mobile/package.jsonremoved), which conflicts with the PR title/description indicating the mobile app deliverable is included. If the app is meant to be part of this PR, the mobile workspace (including its package.json) should be present; otherwise please update the PR description (and any repo docs referring toapps/mobile) to match the actual change.
apps/mobile/metro.config.js:1 - Removing
apps/mobile/metro.config.jswill break the standard Expo monorepo setup (Metro workspace resolution) ifapps/mobileis still expected to build in this repo. If the mobile app remains in scope, keep an appropriate Metro config (watchFolders/nodeModulesPaths/disableHierarchicalLookup) rather than deleting it.
apps/mobile/.gitignore:1 - Deleting the mobile app’s
.gitignoreremoves ignore patterns for sensitive native artifacts (e.g., signing keys/provisioning profiles) and local env files. If the goal is “repo-wide secret .gitignore hardening” (per PR description), these patterns should be preserved elsewhere (e.g., root .gitignore) rather than being dropped.
apps/mobile/app.json:1 apps/mobile/app.jsonis removed here, but the PR description calls out EAS/TestFlight-ready configuration (bundle id, runtimeVersion, update channels, Insights, etc.). If the mobile app is still in scope, this config needs to exist somewhere (app.json/app.config.* + eas.json) so builds and updates can be reproduced.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Expo SDK 55 RN app (mobile deliverable) + the vendored protocol it depends on. Squashed snapshot of the app+protocol scope of build/mobile-ui (independent of the gateway-terraform PR).
Contents
Verification
tsc --noEmit clean; expo export (iOS) bundles; no secrets committed (swept).
Notes
Data layer is the mock gateway until ColeMurray/background-agents@a7b968f is deployed; the real HTTP/WS impl drops into the same seam.