Conversation
* Use the `merge` API from `containers` to perform each merge in one go. * Use lazy merge operations for both; this is more consistent.
If we decide to include this, we can use it for `IntMap` too.
|
I did a fancy useless-deletion detection thing for |
| data Changed a | ||
| = Unchanged a | ||
| | Changed a | ||
| deriving (Functor) |
There was a problem hiding this comment.
Are there any speed benefits to making this newtype Changed a = Changed (ChangedTag, a)? Or does that, as I imagine, compile down to the same thing?
There was a problem hiding this comment.
See my comment from a minute ago.
There was a problem hiding this comment.
Lazy pairs are kind of challenging to compile, so yeah, it's really between what @treeowl suggested and what's already written. (But I don't think this issue should block anything on this MR.)
| data Changed a | ||
| = Unchanged a | ||
| | Changed a | ||
| deriving (Functor) |
There was a problem hiding this comment.
Should I change this to data Changed a = Changed !Bool a or similar? I'll have to look at Core to see if GHC will unbox it nicely in that case. Might be an improvement.
|
Haha, this kind of thing is exactly why I got you to make Data.Map.Merge in the first place, it's kind of funny that you'd also end up helping us replace our old awkward merges with it. :D |
lpsmith
added
clean up
|
Moved to reflex-frp/patch#3 |
5 participants
Use the
containersmerge interface to improve efficiency.Make strictness consistent.